Update all browsers data for text-orientation CSS property #27189
Conversation
This PR updates and corrects version values for all browsers for the `text-orientation` CSS property. The data comes from manual testing, running test code through BrowserStack, SauceLabs, custom VMs and/or locally. Test Code: ``` (Using bcd.testCSSProperty() from the collector) ```
queengooborg
added
the
data:css
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
| @@ -105,7 +105,7 @@ | |||
| }, | |||
| { | |||
| "alternative_name": "sideways-right", | |||
| "version_added": "≤72" | |||
| "version_added": "41" | |||
There was a problem hiding this comment.
According to https://bugzilla.mozilla.org/show_bug.cgi?id=1057329, sideways-right is already parsed since Firefox 35, so we could add a partial implementation since then.
Otherwise, Firefox 44 seems correct in terms of functionality: https://bugzilla.mozilla.org/show_bug.cgi?id=1193488
| @@ -67,7 +67,7 @@ | |||
| "opera": "mirror", | |||
| "opera_android": "mirror", | |||
| "safari": { | |||
| "version_added": "≤13.1" | |||
| "version_added": "10.1" | |||
There was a problem hiding this comment.
Renamed from vertical-right via WebKit/WebKit@608ae58 in WebKit 602.1.10 before Safari 10 (602.1.50).
| "version_added": "10.1" | |
| "version_added": "10" |
Let's add the vertical-right value, which was supported since the beginning, see WebKit/WebKit@87bbc48 in WebKit 534.24 before Safari 5.1 (534.48).
| @@ -94,7 +94,7 @@ | |||
| }, | |||
| { | |||
| "alternative_name": "sideways-right", | |||
| "version_added": "≤83" | |||
| "version_added": "25" | |||
There was a problem hiding this comment.
Given that Chrome 25 used WebKit 537.22, I would expect this alternative name to also show up in Safari 7 (537.71).
Landed via WebKit/WebKit@57ac98a in WebKit 537.21, so it should also be in Safari 7.
Can we add it while we're here?
PS: Shouldn't we extract a separate subfeature for sideways-right? Based on WebKit/WebKit@b7bdc56, it was removed from the spec, so setting standard_track: true and deprecated: true should be the right thing to do.
This PR updates and corrects version values for all browsers for the
text-orientationCSS property. The data comes from manual testing, running test code through BrowserStack, SauceLabs, custom VMs and/or locally.Test Code: