Skip to content

Remove api.SnapEvent.SnapEvent from BCD #26687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

queengooborg
Copy link
Contributor

This PR removes the SnapEvent member of the SnapEvent API from BCD. The collector reports that the constructor is an illegal constructor in Chromium.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/SnapEvent/SnapEvent

This PR removes the `SnapEvent` member of the `SnapEvent` API from BCD. The collector reports that the constructor is an illegal constructor in Chromium.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/SnapEvent/SnapEvent
@queengooborg queengooborg added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update This PR needs a corresponding update to mdn/content to update the documentation labels May 1, 2025
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label May 1, 2025
Copy link
Contributor

github-actions bot commented May 1, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reported the issue: https://issues.chromium.org/issues/415848477

Instead of removing the data, we could set partial_implementation: true with notes pointing to the issue

@queengooborg
Copy link
Contributor Author

In Chrome, "Illegal constructor" means that a constructor has not been implemented and exposed, which means that it's not supported. Using partial implementation for a feature that does not have support doesn't seem like the right call.

We can always keep the MDN page around, however, and then reattach the BCD table once the feature is supported?

@caugner
Copy link
Contributor

caugner commented May 7, 2025

Using partial implementation for a feature that does not have support doesn't seem like the right call.

The alternative is to set version_added: false, but with the impl_url. That should be fine, no?

I would assume that it's either a bug in the spec or in Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs content update This PR needs a corresponding update to mdn/content to update the documentation size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants