-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update Safari + iOS data for optgroup.disabled #26644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, thanks! 🙌
Unfortunately, I missed that for HTML attributes, we just set version_added: false
if there is no effect (rather than marking support as partial), but can add notes
to be explicit.
However, we should also update api.HTMLOptGroupElement.disabled
here, similar to HTMLInputElement.webkitdirectory
, where being able to set (and read) the property is considered partial_implementation
(even if there is no other observable effect):
browser-compat-data/api/HTMLInputElement.json
Lines 3269 to 3278 in b5295a8
"safari_ios": [ | |
{ | |
"version_added": "18.4" | |
}, | |
{ | |
"version_added": "11.3", | |
"partial_implementation": true, | |
"notes": "The property can be set, but has no effect (see [bug 271705](https://webkit.org/b/271705))." | |
} | |
], |
I tested back to iOS 4.3 (with this test), and the disabled
property of HTMLOptGroupElement
can be set (and read), so we can set version_added: "≤4.3"
with partial_implementation: true
and notes: "The property can be set, but has no effect (see [bug 227042](https://webkit.org/b/227042))."
"safari": [ | ||
{ | ||
"version_added": "7", | ||
"impl_url": "https://trac.webkit.org/changeset/118772" | ||
}, | ||
{ | ||
"version_added": "≤6", | ||
"version_removed": "7", | ||
"partial_implementation": true, | ||
"notes": "The attribute is exposed, but has no effect." | ||
} | ||
], | ||
"safari_ios": { | ||
"version_added": "≤11.3", | ||
"impl_url": "https://webkit.org/b/227042", | ||
"partial_implementation": true, | ||
"notes": "The attribute is exposed, but has no effect." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"safari": [ | |
{ | |
"version_added": "7", | |
"impl_url": "https://trac.webkit.org/changeset/118772" | |
}, | |
{ | |
"version_added": "≤6", | |
"version_removed": "7", | |
"partial_implementation": true, | |
"notes": "The attribute is exposed, but has no effect." | |
} | |
], | |
"safari_ios": { | |
"version_added": "≤11.3", | |
"impl_url": "https://webkit.org/b/227042", | |
"partial_implementation": true, | |
"notes": "The attribute is exposed, but has no effect." | |
"safari": { | |
"version_added": "7", | |
"notes": "Before Safari 7, the attribute can be set, but has no effect." | |
}, | |
"safari_ios": { | |
"version_added": "false", | |
"impl_url": "https://webkit.org/b/227042", | |
"notes": "The attribute can be set, but has no effect." |
@telic Please let me know if you have any questions about my review comments, of if you would like to me to finish up the PR. |
Summary
Record incomplete support for the disabled attribute on optgroup elements in desktop Safari v6 and current versions of iOS Safari.
Test results and supporting details
@caugner created a JS Bin test case and was able to reproduce back to iOS 11.2.
I tested in:
Commit history found from bug 87614 suggests this issue was likely present in desktop Safari 6 (introduced in 536.11), but fixed by version 7 (fix merged in 537.43.1). I'm unable to test whether it was actually working properly earlier.
There is an unresolved bug for iOS and iPadOS.
Related issues
Fixes #26219