Skip to content

Update Safari + iOS data for optgroup.disabled #26644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

telic
Copy link

@telic telic commented Apr 27, 2025

Summary

Record incomplete support for the disabled attribute on optgroup elements in desktop Safari v6 and current versions of iOS Safari.

Test results and supporting details

@caugner created a JS Bin test case and was able to reproduce back to iOS 11.2.

I tested in:

  • Safari 17.6 on MacOS 12.7.6 - passes
  • Safari 18.4 on MacOS 15.4.1 - passes
  • iOS 18.3.1 - fails

Commit history found from bug 87614 suggests this issue was likely present in desktop Safari 6 (introduced in 536.11), but fixed by version 7 (fix merged in 537.43.1). I'm unable to test whether it was actually working properly earlier.

There is an unresolved bug for iOS and iPadOS.

Related issues

Fixes #26219

@github-actions github-actions bot added data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML size:s [PR only] 7-24 LoC changed labels Apr 27, 2025
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@caugner caugner self-requested a review April 28, 2025 13:45
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thanks! 🙌

Unfortunately, I missed that for HTML attributes, we just set version_added: false if there is no effect (rather than marking support as partial), but can add notes to be explicit.

However, we should also update api.HTMLOptGroupElement.disabled here, similar to HTMLInputElement.webkitdirectory, where being able to set (and read) the property is considered partial_implementation (even if there is no other observable effect):

"safari_ios": [
{
"version_added": "18.4"
},
{
"version_added": "11.3",
"partial_implementation": true,
"notes": "The property can be set, but has no effect (see [bug 271705](https://webkit.org/b/271705))."
}
],

I tested back to iOS 4.3 (with this test), and the disabled property of HTMLOptGroupElement can be set (and read), so we can set version_added: "≤4.3" with partial_implementation: true and notes: "The property can be set, but has no effect (see [bug 227042](https://webkit.org/b/227042))."

Comment on lines +68 to +84
"safari": [
{
"version_added": "7",
"impl_url": "https://trac.webkit.org/changeset/118772"
},
{
"version_added": "≤6",
"version_removed": "7",
"partial_implementation": true,
"notes": "The attribute is exposed, but has no effect."
}
],
"safari_ios": {
"version_added": "≤11.3",
"impl_url": "https://webkit.org/b/227042",
"partial_implementation": true,
"notes": "The attribute is exposed, but has no effect."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"safari": [
{
"version_added": "7",
"impl_url": "https://trac.webkit.org/changeset/118772"
},
{
"version_added": "≤6",
"version_removed": "7",
"partial_implementation": true,
"notes": "The attribute is exposed, but has no effect."
}
],
"safari_ios": {
"version_added": "≤11.3",
"impl_url": "https://webkit.org/b/227042",
"partial_implementation": true,
"notes": "The attribute is exposed, but has no effect."
"safari": {
"version_added": "7",
"notes": "Before Safari 7, the attribute can be set, but has no effect."
},
"safari_ios": {
"version_added": "false",
"impl_url": "https://webkit.org/b/227042",
"notes": "The attribute can be set, but has no effect."

@caugner caugner changed the title partial support of optgroup.disabled in Safari and iOS Update Safari + iOS data for optgroup.disabled Apr 28, 2025
@caugner
Copy link
Contributor

caugner commented May 9, 2025

@telic Please let me know if you have any questions about my review comments, of if you would like to me to finish up the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html.elements.optgroup.disabled - recent iOS does not support disabled optgroup
2 participants