bootutil: (refactor) split image_validate.c into separate files #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move bootutil_find_key(), bootutil_img_hash(), and bootutil_img_security_cnt() into their own source files for cleaner No functional changes have been made. Signed-off-by: Maulik Patel <maulik.patel@arm.com> Change-Id: I5d3f4a1327356238e5865dba91b4ec251ffcf1aa
maulik-arm
requested review from
nordicjm,
de-nordic,
almir-okato,
davidvincze and
d3zd3z
as code owners
|
Hello, @de-nordic , @almir-okato , @nordicjm , if I can have your review comments please, very much appreciated. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As we add more config-dependent hooks in image_validate.c, the giant #ifdefs were becoming unmanageable. Splitting each core helper into its own file lays the groundwork for cleaner feature flags and easier future refactoring.
Move bootutil_find_key(), bootutil_img_hash(), and bootutil_img_security_cnt() into their own source files for cleaner
No functional changes have been made.