bootutil: Unify app_max_size() implementations #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchy
force-pushed
the
bugfix/swap/Unify_max_app_size_methods
branch
3 times, most recently
from
0a7e9a6 to
84cf14a
Compare
ahasztag
force-pushed
the
bugfix/swap/Unify_max_app_size_methods
branch
from
84cf14a to
ade4b0d
Compare
tomchy
force-pushed
the
bugfix/swap/Unify_max_app_size_methods
branch
from
f7abf5d to
c06e0c3
Compare
tomchy
force-pushed
the
bugfix/swap/Unify_max_app_size_methods
branch
14 times, most recently
from
f68249e to
862d9fa
Compare
nordicjm
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
swap using move/offset OK, no clue about swap using scratch, defer to @taltenbach
taltenbach
reviewed
Jul 9, 2025
Remove redundant application size calculations in favor of a swap-specific function, implemented inside swap_<type>.c. In this way, slot sizes use the same restrictions as image validation. Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
tomchy
force-pushed
the
bugfix/swap/Unify_max_app_size_methods
branch
from
862d9fa to
5254b75
Compare
|
LGTM, @tomchy feel free resolve all open threads (I can't do it myself) |
taltenbach
approved these changes
Jul 9, 2025
de-nordic
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant application size calculations in favor of a swap-specific function, implemented inside
swap_<type>.c. In this way, slot sizes use the same restrictions as image validation.This change is a follow-up PR to the discussion in the #2283.