RFCS_0013 - Add sensor_index field to mavlink_scaled_imu_t typedef
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
changed the title
mavlink_scaled_imu_t typedefmavlink_scaled_imu_t typedef
|
The same applies for SCALED_PRESSURE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC is to evaluate the impacts of adding a sensor index field to the definition of
mavlink_scaled_imu_tso that a single typdef can be used for multiple IMU hardware instances.Currently there exist typedefs for
mavlink_scaled_imu2_tandmavlink_scaled_imu3_tbecause of the limitation of themavlink_scaled_imu_tdefinition to address multiple instances.This PR adds a field to the typedef, updates the message length, augments the CRC, and implies remaining implementation aspects within
mavlink_msg_scaled_imu.hAdding this field would allow for the deprecation of
mavlink_msg_scaled_imu2.handmavlink_msg_scaled_imu3.hand would allow for additional code reduction in projects utilizing the protocol.Please let me know how this RFC can be improved, and to clue me in where I might not understand the workflow in this RFC process. Thanks.
-Mark