Skip to content

Conversation

DonLakeFlyer
Copy link
Contributor

  • ToolStrip is now transparent as well
  • Transparency respects Palette Themes

Screenshot 2025-10-13 at 7 03 59 PM

Screenshot 2025-10-13 at 7 04 18 PM

* ToolStrip is now transparent as well
* Transparency respects Palette Themes
@DonLakeFlyer DonLakeFlyer requested a review from Copilot October 14, 2025 02:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances toolbar transparency support by extending it to ToolStrip components and ensuring transparency properly respects palette themes.

  • Introduces new transparent color properties windowTransparent and windowTransparentText to the QGC palette system
  • Updates all toolbar indicators to use the new transparent text color instead of toolbarText
  • Makes ToolStrip components transparent and removes deprecated properties

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/QmlControls/QGCPalette.h Adds new transparent color properties and removes unused ones
src/QmlControls/QGCPalette.cc Defines transparent color values and removes deprecated single colors
src/QmlControls/ToolStrip.qml Makes ToolStrip background transparent and removes title property
src/QmlControls/ToolStripHoverButton.qml Updates button to use transparent colors and removes background
src/QmlControls/FlyViewToolBar.qml Implements transparent toolbar with gradient background
src/QmlControls/FlyViewToolBarIndicators.qml Removes background container to support transparency
Multiple indicator files Updates text colors to use new transparent text color

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +134 to 135
((control.enabled && control.hovered) ? qgcPal.toolStripHoverColor : "transparent")
}
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchors.fill: parent property was removed but the Rectangle still needs proper positioning. Consider adding explicit positioning or verify this Rectangle is properly sized without anchors.

Copilot uses AI. Check for mistakes.

@DonLakeFlyer DonLakeFlyer merged commit bad4b15 into master Oct 14, 2025
18 checks passed
@DonLakeFlyer DonLakeFlyer deleted the TransparentWork branch October 14, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant