Fix/telemetry color to hex #13209
Merged
Fix/telemetry color to hex #13209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash to a single commit so we don't have history of the changes which aren't correct? |
new-tonAA
force-pushed
the
fix/telemetry-color-to-hex
branch
from
fe719de to
6e85f71
Compare
|
Hi! I’ve squashed the commits into one and rebased on the latest master as you suggested. Please take a look! |
new-tonAA
force-pushed
the
fix/telemetry-color-to-hex
branch
from
4c09cd2 to
6e85f71
Compare
Fixes a bug in the telemetry color picker dialog where the wrong color value was passed on acceptance. Changed the onAccepted handler to use selectedColor instead of color to ensure the correct hex color value is used when updating telemetry colors. Changes: - Modified colorPickerDialog's onAccepted from: onAccepted: updateColorValue(colorIndex, color)
new-tonAA
force-pushed
the
fix/telemetry-color-to-hex
branch
from
9034fee to
83a60a4
Compare
|
@new-tonAA I linked an issue to this PR, is that issue the same thing you are referring to? |
|
@new-tonAA Perfect, thanks so much for this |
|
Yes that is! Thanks for merging! Glad to contribute!
Sent from my iPhone
…------------------ Original ------------------
From: Holden Ramsey ***@***.***>
Date: Fri,Jul 25,2025 10:11 PM
To: mavlink/qgroundcontrol ***@***.***>
Cc: new-tonAA ***@***.***>, Mention ***@***.***>
Subject: Re: [mavlink/qgroundcontrol] Fix/telemetry color to hex (PR #13209)
HTRamsey left a comment (mavlink/qgroundcontrol#13209)
@new-tonAA I linked an issue to this PR, is that issue the same thing you are referring to?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the telemetry color picker dialog where the wrong color value was passed on acceptance.
Changed the
onAcceptedhandler to useselectedColorinstead ofcolorto ensure the correct hex color value is used when updating telemetry colors.Changes
colorPickerDialog'sonAcceptedfrom:Fixes #13216