Vehicle: Minor Telemetry Fixes #13192
Draft
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really odd. I swear I've looked at voltage in my own flights and it seemed fine. But it sure seems wrong in the code. |
Sorry, looked at change wrong. This doesn't really change the voltage values does it? Not sure where the problem is and how it fixes it. I get voltage values fine with my vehicle. |
|
Yeah I don't have any issues either. I was going to look into it more later. But I did find that minDistance of VehicleDistanceSensorFactGroup was never set so I added this anyways |
|
Any reason for this to be Draft? Seems like a good fix that should go in to master and Stable |
|
Was trying to figure out if I could reproduce the original issue too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.