Skip to content

Conversation

HTRamsey
Copy link
Collaborator

@HTRamsey HTRamsey commented Jul 9, 2025

Closes #13172
We don't need all these individual modules. They just add complexity

@HTRamsey HTRamsey force-pushed the dev-qml-modules-cleanup branch 3 times, most recently from cbc9c04 to ac55b90 Compare July 9, 2025 18:45
@HTRamsey HTRamsey requested review from DonLakeFlyer and Copilot July 9, 2025 21:22
Copilot

This comment was marked as outdated.

@HTRamsey HTRamsey force-pushed the dev-qml-modules-cleanup branch from ac55b90 to d58a834 Compare July 9, 2025 23:28
@HTRamsey HTRamsey requested a review from Copilot July 10, 2025 00:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies QML module usage by removing individual QGroundControl submodules (Palette, ScreenTools, Templates, etc.) and consolidating them under the QGroundControl and QGroundControl.Controls URIs.

  • Unified QML imports to import QGroundControl and import QGroundControl.Controls, removing all import QGroundControl.Palette, import QGroundControl.ScreenTools, and related module imports.
  • Updated QGroundControlQmlGlobal to register all QML types under the consolidated QGroundControl URI and removed the legacy hasMAVLinkInspector property.
  • Cleaned up CMake files to remove the ScreenToolsModule and adjust QML module registrations accordingly.
  • Updated documentation to reflect the new import patterns.

Reviewed Changes

Copilot reviewed 300 out of 388 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/QmlControls/QGroundControlQmlGlobal.h Removed hasMAVLinkInspector Q_PROPERTY in line with consolidation.
src/QmlControls/QGroundControlQmlGlobal.cc Changed various qmlRegister* URIs from legacy modules to QGroundControl.
src/QmlControls/CMakeLists.txt Deleted ScreenToolsModule and updated QML module registration.
src/CMakeLists.txt Removed linkage to the removed ScreenToolsModule.
docs/en/qgc-dev-guide/user_interface_design/font_palette.md Updated example imports to use consolidated modules.
Comments suppressed due to low confidence (2)

src/QmlControls/QGroundControlQmlGlobal.h:113

  • Removing the hasMAVLinkInspector Q_PROPERTY may break QML references expecting this property. Verify and update all QML code that accesses QGroundControl.hasMAVLinkInspector or remove those references.
    Q_PROPERTY(bool     hasAPMSupport           READ hasAPMSupport              CONSTANT)

src/QmlControls/QGroundControlQmlGlobal.cc:83

  • The URI for FactValueGrid was changed from QGroundControl.Templates to QGroundControl. Ensure that any QML files importing the old module have been updated to import QGroundControl 1.0 so they can resolve the new URI.
    qmlRegisterUncreatableType<FactValueGrid>           ("QGroundControl",                       1, 0, "FactValueGrid",       "Reference only");

@HTRamsey HTRamsey force-pushed the dev-qml-modules-cleanup branch 2 times, most recently from d100ba1 to 2585a8e Compare July 10, 2025 09:22
@HTRamsey HTRamsey force-pushed the dev-qml-modules-cleanup branch from 2585a8e to 9506ecb Compare July 10, 2025 09:31
@HTRamsey HTRamsey closed this Jul 21, 2025
@HTRamsey HTRamsey deleted the dev-qml-modules-cleanup branch July 21, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secondary developmen:module "QGroundControl.AutoPilotPlugins.PX4"

1 participant