Skip to content

Utilities: Add GDAL #12848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Utilities: Add GDAL #12848

wants to merge 1 commit into from

Conversation

HTRamsey
Copy link
Collaborator

Just a test

@HTRamsey HTRamsey force-pushed the dev-cmake-gdal branch 2 times, most recently from a9393bb to 48c0cf7 Compare May 14, 2025 19:26
@Ryanf55
Copy link
Contributor

Ryanf55 commented May 16, 2025

Compare it to my attempt which compiles if you want: master...Ryanf55:qgroundcontrol:add-gdal-map-provider

@github-actions github-actions bot added the stale label Jun 15, 2025
@HTRamsey HTRamsey force-pushed the dev-cmake-gdal branch 5 times, most recently from bb7d738 to 293ce71 Compare July 10, 2025 00:54
@HTRamsey HTRamsey requested a review from Copilot July 10, 2025 11:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds PROJ and GDAL dependencies to the project, updates the installation scripts, and scaffolds a new GDALHelper utility.

  • Updates macOS and Debian setup scripts to install PROJ
  • Introduces empty GDALHelper header and source files
  • Integrates PROJ and GDAL via CPM in the CMakeLists

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/setup/install-dependencies-osx.sh Added proj to the brew install line
tools/setup/install-dependencies-debian.sh Added libproj-dev and proj-bin apt packages
src/Utilities/Shape/GDALHelper.h Added empty GDALHelper namespace scaffold
src/Utilities/Shape/GDALHelper.cc Added empty implementation file for GDALHelper
src/Utilities/Shape/CMakeLists.txt Added PROJ and GDAL packages via CPM and linked GDAL
Comments suppressed due to low confidence (6)

src/Utilities/Shape/GDALHelper.cc:17

  • No tests cover the new GDALHelper scaffolding; once methods are implemented, add unit tests to verify their behavior.
}

tools/setup/install-dependencies-osx.sh:11

  • GDAL is not installed on macOS; you should include gdal (or the appropriate formula) in the brew install line to match the new GDAL integration.
brew install cmake ninja ccache git pkgconf create-dmg mold proj

tools/setup/install-dependencies-debian.sh:116

  • GDAL development libraries (libgdal-dev) or tools (gdal-bin) are not installed; add the appropriate packages so GDAL builds correctly on Debian.
apt-get install -y -qq --no-install-recommends \

src/Utilities/Shape/CMakeLists.txt:33

  • The PROJ package is added via CPM but never linked to the target; consider adding target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE PROJ::proj) after the PROJ block.
CPMAddPackage(

src/Utilities/Shape/CMakeLists.txt:45

  • [nitpick] The old find_package and related lines are commented out; remove or update these to keep the CMakeLists clean.
# find_package(PROJ REQUIRED CONFIG)

src/Utilities/Shape/GDALHelper.h:12

  • [nitpick] The GDALHelper namespace is empty; consider adding at least a placeholder function declaration or a TODO comment so it's clear what belongs here.
namespace GDALHelper

@github-actions github-actions bot removed the stale label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants