Skip to content

Conversation

vryabokon1705
Copy link
Contributor

Fix mavlink inspector unselection issue

Description

Added simple workaround for mavlink inspector unselection issue. Plus fix bug related to misuse of const_iterator.

Test Steps

  • build QGrounControl from souce
  • start QGrounControl.
  • connect vehicle
  • open Mavlink Inspector page
  • select some message fields. Charts must appear
  • deselect some of the previously selected fields. Unselected fileds must disappear from charts and checkboxes must be enabled
  • select the some of the previously unselected fields. Charts must appear

Checklist:

Related Issue

11197

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@HTRamsey
Copy link
Collaborator

Thank you for doing this!

id: controller
}

function updateEnabledStatus(repeater, message, chart) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clean up the tabbing here? And the extra empty line after the function line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@DonLakeFlyer
Copy link
Contributor

All good except for the simple tabbing cleaning up. Thanks for the fix.

@HTRamsey HTRamsey merged commit 7fb2fc9 into mavlink:master Mar 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants