Fix "Change Airspeed" guided action #12505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenp02
force-pushed
the
bugfix/fix-change-airspeed-action
branch
from
d6e57df to
33f421f
Compare
|
So this happens so often, mostly with ArduPilot that QGC has a system to remap parameters names based on version. That way the main code can stay the same once updated to support remapping. You can see the remapping here in ArduCopter: https://github.com/mavlink/qgroundcontrol/blob/master/src/FirmwarePlugin/APM/ArduCopterFirmwarePlugin.cc#L109. Then you use |
|
Sounds good, will update this to use that. |
Updated maximum and minimum airspeed parameter names in ArduPlane. This restores the "Change Airspeed" Guided mode action. Compatibility with the previous parameter names has been maintained.
Made the default value of the airspeed slider in the "Change Airspeed" Guided mode action match the current airspeed, to match the behavior of the "Change Altitude" action.
rubenp02
force-pushed
the
bugfix/fix-change-airspeed-action
branch
from
33f421f to
581a1dc
Compare
DonLakeFlyer
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "Change Airspeed" guided action
Description
This PR restores the "Change Airspeed" Guided mode action for ArduPilot fixed-wing aircraft, which was inadvertently disabled due to changes in ArduPilot's parameter names. Additionally, it updates the airspeed slider's default value to the current airspeed, for consistency with the "Change Altitude" action.
Support new APM airspeed limits parameter names:
Added support for updated maximum and minimum airspeed parameter names in ArduPilot. This restores the "Change Airspeed" Guided mode action. Compatibility with the previous parameter names has been maintained.
Set airspeed slider default to current airspeed:
Made the default value of the airspeed slider in the "Change Airspeed" Guided mode action match the current airspeed, to match the behavior of the "Change Altitude" action.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.