-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix: Check if Arch and Use correct GStreamer paths for Arch Linux #12401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QGroundControl’s FindGStreamer.cmake assumed a Debian-based path structure (/usr/lib/x86_64-linux-gnu/), causing build failures on Arch Linux. This fix dynamically detects Arch Linux using /etc/os-release and correctly sets PKG_CONFIG_PATH and GSTREAMER_LIB_PATH for Arch (/usr/lib/). This preserves Debian-based paths for other Linux distributions while enabling successful builds on Arch.
Probably need to rebase because I cleaned up that file a bit more yesterday |
Thanks, that worked! |
Did my method solve your problem? Trying to avoid manually listing distributions |
and other problem
this didnt work well i have both wersion but it sees 5.15.16 |
Trying to avoid having distribution specific cmake code. Can you make this use find_path or Exists or something like that instead? |
as far as the other problem, I generally build using the qt-cmake file from the target Qt installation which makes sure all the build parameters are set correctly and the right Qt gets used. |
Ok |
I build using these guide steps https://docs.qgroundcontrol.com/master/en/qgc-dev-guide/getting_started/index.html |
I'd personally use "C:\Qt\6.8.2\msvc2022_64\bin\qt-cmake.bat" instead of calling cmake directly |
It's windows specific |
Yup sorry, working on a windows pc right now and didn't fix the path for you |
Fix: Correct GStreamer Paths for Arch Linux in FindGStreamer.cmake
Description
QGroundControl’s FindGStreamer.cmake assumes a Debian-based library path structure (/usr/lib/x86_64-linux-gnu/). This causes build failures on Arch Linux, where libraries are located in /usr/lib/ instead.
This PR:
Test Steps
To Reproduce the Original Issue (Before Fix):
Checklist:
Related Issue
N/A (first report)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.