-
Notifications
You must be signed in to change notification settings - Fork 4.3k
CMake: Fix MacOS GStreamer RPath #12042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DonLakeFlyer If this doesn't work can you see if you can try something here? It seems the issue was not fixing the rpath for the extra included gstreamer libs like gstallocators. We need to make this such that it works for whatever gstreamer libs are included rather than manually specifying them With this we might be able to link to the plugins again but I'm not entirely sure yet |
Hmm, not booting for me. I got this once:
But then it went away which is strange. I'll try to figure this one out. |
I didn't add this step from the previous stable |
Oh actually you may have to check permissions on gst-plugin-scanner. I had to mark it as executable for linux |
My previous comment on what was wrong is incorrect. I still had gstreamer framework installed on machine when I tried running the build QGC. It continues to be an rpath issue on gstreamer libs. Trying to figure out how to fix it. |
It should be okay to still have a system version installed once we get everything correct |
Right, but you have to keep in mind while testing to remove it to prove it works without it. Why I screwed up originally. I've been trying some simple things based on what stable does in it's cmake to fix this but can't find anything that works. It you look at Stable 4.4 cmake support you'll see a much more complex pile of gstreamer install stuff which I assume works (prepare_gstreamer_framework.sh, osxrelocator.py, QGCDeploy.cmake). I'll give it a try. But it's gonna take me a while to get to it. Somewhat involved. |
Hopefully we can get it to at least run without crashing relatively easily. I can make a PR to use the older v4.4 method the best I can and just get you to test it and fix any last parts if you want |
Taken from previous stable
qgroundcontrol/QGCPostLinkInstaller.pri
Line 22 in 990ed12