Skip to content

Conversation

HTRamsey
Copy link
Collaborator

Taken from previous stable

QMAKE_POST_LINK += && install_name_tool -change /Library/Frameworks/GStreamer.framework/Versions/1.0/lib/GStreamer @executable_path/../Frameworks/GStreamer.framework/Versions/1.0/lib/GStreamer $${TARGET}.app/Contents/MacOS/$${TARGET}

@HTRamsey HTRamsey requested a review from DonLakeFlyer October 29, 2024 00:06
@HTRamsey
Copy link
Collaborator Author

HTRamsey commented Oct 29, 2024

@DonLakeFlyer If this doesn't work can you see if you can try something here? It seems the issue was not fixing the rpath for the extra included gstreamer libs like gstallocators. We need to make this such that it works for whatever gstreamer libs are included rather than manually specifying them

With this we might be able to link to the plugins again but I'm not entirely sure yet

@DonLakeFlyer
Copy link
Contributor

Hmm, not booting for me. I got this once:

2024-10-29 12:52:41.159 QGroundControl[10297:14468116] WARNING: AVCaptureDeviceTypeExternal is deprecated for Continuity Cameras. Please use AVCaptureDeviceTypeContinuityCamera and add NSCameraUseContinuityCameraDeviceType to your Info.plist.
arch: /Applications/QGroundControl.app/Contents/MacOS/../Frameworks/GStreamer.framework/Versions/1.0/libexec/gstreamer-1.0/gst-plugin-scanner isn't executable

(.:10297): GStreamer-WARNING **: 12:52:41.244: External plugin loader failed. This most likely means that the plugin loader helper binary was not found or could not be run. You might need to set the GST_PLUGIN_SCANNER environment variable if your setup is unusual. This should normally not be required though.

But then it went away which is strange. I'll try to figure this one out.

@HTRamsey
Copy link
Collaborator Author

I didn't add this step from the previous stable ln -sf $${TARGET}.app/Contents/Frameworks $${TARGET}.app/Contents/Frameworks/GStreamer.framework/Versions/1.0/libexec/Frameworks

@HTRamsey
Copy link
Collaborator Author

Oh actually you may have to check permissions on gst-plugin-scanner. I had to mark it as executable for linux

@DonLakeFlyer
Copy link
Contributor

My previous comment on what was wrong is incorrect. I still had gstreamer framework installed on machine when I tried running the build QGC. It continues to be an rpath issue on gstreamer libs. Trying to figure out how to fix it.

@HTRamsey
Copy link
Collaborator Author

It should be okay to still have a system version installed once we get everything correct

@DonLakeFlyer
Copy link
Contributor

DonLakeFlyer commented Oct 30, 2024

Right, but you have to keep in mind while testing to remove it to prove it works without it. Why I screwed up originally.

I've been trying some simple things based on what stable does in it's cmake to fix this but can't find anything that works. It you look at Stable 4.4 cmake support you'll see a much more complex pile of gstreamer install stuff which I assume works (prepare_gstreamer_framework.sh, osxrelocator.py, QGCDeploy.cmake). I'll give it a try. But it's gonna take me a while to get to it. Somewhat involved.

@HTRamsey
Copy link
Collaborator Author

Hopefully we can get it to at least run without crashing relatively easily. I can make a PR to use the older v4.4 method the best I can and just get you to test it and fix any last parts if you want

@HTRamsey HTRamsey merged commit cb58f99 into mavlink:master Nov 18, 2024
7 checks passed
@HTRamsey HTRamsey deleted the dev-cmake-macos branch November 18, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants