Rework/Fix validation support #12007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add validation support to QGCTextField * Rework FactTextField to use new QGCTextField support * Validation errors tracked by count not bool: globals.validationErrorCount * New mainWindow.allowViewSwitch function to check whether view switch should be allowed
|
@HTRamsey Don't know if you want to review these detailed qml things? Would be good for sanity check but also don't want to waste your time. Previously most of the internal ui stuff had no reviewers. |
|
Merging so I can move on to the remaining fixes for #11994 |
|
I'm not nearly as familiar with the QML code as I am the C++, but if there's something in particular I can always double check for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11994