Button hover highlight #11836
Merged
Button hover highlight #11836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before buttons would only change color when pressed or checked, but had no visual response when hovered. Now buttons will will have a faint highlight when hovered and a full highlight when pressed or checked
This is more similar to Google/Apple button design It is also better for when the color Palette is overwritten with a different color scheme where button where buttonText and buttonHighlight might not look good when mixed together.
|
Perfect thanks |
|
Is it intended to leave highlight rect with sharp corners? Consider setting it's radius to backRadius too |
gillamkid
added a commit
to gillamkid/qgroundcontrol
that referenced
this pull request
Sep 13, 2024
As noticed here: mavlink#11836 (comment) Contribution Sponsor: Firestorm (launchfirestorm.com)
|
@funyarinpa01, good catch, fixed in this new PR |
DonLakeFlyer
pushed a commit
that referenced
this pull request
Sep 13, 2024
As noticed here: #11836 (comment) Contribution Sponsor: Firestorm (launchfirestorm.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did 2 things in this PR
Make button icon colors same as text color
Some of the icons where button color (gray), but i changed that so the icon color would be the same as the text color in the button. This is more similar to Google/Apple button design. It is also better for when the color Palette is overwritten with a different color scheme where button where buttonText and buttonHighlight might not look good when mixed together.
Sponsor
This contribution was sponsored by Firestorm
before/after QGCButton
before-qgc-button.mp4
after-qgc-button.mp4
before/after app settings menu
before-settings-menu.mp4
after-settings-menu.mp4
before/after menu buttons
before-vehicle-setup.mp4
after-vehicle-setup.mp4
icon color change justification
make it more similar to google/apple icon buttons
google icon buttons
apple icon buttons