Fix QGC icon (bloated Q) #11834
Merged
Fix QGC icon (bloated Q) #11834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where did you find the icon? Did you make a new one? I have a collection of those, perhaps we should start a repo. One tiny nitpick request, can you please run the SVGs through an optimizer and minifier? It will help get rid of metadata and clean it up |
HTRamsey
requested review from
DonLakeFlyer
and removed request for
DonLakeFlyer
gillamkid
force-pushed
the
gillamkid/fix-bloated-icon
branch
from
866a27b to
090756e
Compare
|
@mrpollo I modified the original icon using an svg editor (inkskape on Ubuntu). I ran the icons through a minifier and it reduced their size by about half! |
gillamkid
changed the title
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
dagar
approved these changes
Sep 11, 2024
MaEtUgR
approved these changes
Sep 11, 2024
gillamkid
force-pushed
the
gillamkid/fix-bloated-icon
branch
from
090756e to
918a25b
Compare
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
|
Thanks @gillamkid |
The QGC icon shown in the top left corner of the app did not match the typical QGC icon seen everywhere else (icon of QGC shortcut made after an install, icon branding on QGC website, etc). I replaced the instances of the extra-bloated Q with the more common QGC icon Contribution Sponsor: Firestorm (launchfirestorm.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The QGC icon shown in the top left corner of the app did not match the typical QGC icon seen everywhere else (icon of QGC shortcut made after an install, icon branding on QGC website, etc). I replaced the instances of the extra-bloated Q with the more common QGC icon
Sponsor
This contribution was sponsored by Firestorm
Before/After (icon in app)
Before/After (icon in svg editor view to show outline change)