VideoManager: Get the QtMultimedia Alternative Backend Working #11824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-video-qtmultimedia
branch
from
6386764 to
a80bd36
Compare
HTRamsey
changed the title
HTRamsey
force-pushed
the
dev-video-qtmultimedia
branch
3 times, most recently
from
0769d0c to
e48eca5
Compare
HTRamsey
force-pushed
the
dev-video-qtmultimedia
branch
from
e48eca5 to
403ead0
Compare
HTRamsey
force-pushed
the
dev-video-qtmultimedia
branch
from
403ead0 to
783a690
Compare
DonLakeFlyer
reviewed
Sep 6, 2024
| /// Allows the plugin to override the creation of the root (native) window. | ||
| virtual void createRootWindow(QQmlApplicationEngine* qmlEngine); | ||
|
|
||
| /// Allows the plugin to override the creation of VideoManager. |
There was a problem hiding this comment.
Isn't this going to hose custom builds folks who already use this?
There was a problem hiding this comment.
I debated on leaving it, but it's not used anywhere so it does absolutely nothing right now, also i think a custom videomanager doesn't really make much sense like a videoreceiver does.
There was a problem hiding this comment.
but it's not used anywhere so it does absolutely nothing right now
Ok. Was it always like that or was it changed somewhere along the way. Guess we can remove and see if someone yells. I think some amount of this stuff was added by Auterion ages ago for their custom QGC. But they are so far forked from upstream they can never come back, so no longer important.
DonLakeFlyer
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used as a backup for issues with GStreamer