Skip to content

Implement io.Seeker in progress.Reader #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Implement io.Seeker in progress.Reader #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
722763b
Implement io.Seeker in progress.Reader
tulir Jun 12, 2024
4b15e15
Update comment
tulir Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions progress/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package progress

import "io"
import (
"fmt"
"io"
)

// Reader is an [io.ReadCloser] that reports the number of bytes read from it
// via a callback. The callback is called at most every "updateInterval" bytes.
Expand Down Expand Up @@ -51,4 +54,19 @@ func (r *Reader) Close() error {
return nil
}

var _ io.ReadCloser = (*Reader)(nil)
func (r *Reader) Seek(offset int64, whence int) (int64, error) {
seeker, ok := r.inner.(io.ReadSeeker)
if !ok {
return 0, fmt.Errorf("progress.Reader: source reader (%T) is not an io.ReadSeeker", r.inner)
}
n, err := seeker.Seek(offset, whence)
if err != nil {
return 0, err
}
r.readBytes = int(n)
r.progressFn(r.readBytes)
r.lastUpdate = r.readBytes
return n, nil
}

var _ io.ReadSeekCloser = (*Reader)(nil)