Add Preference Center blocks to GrapesJS builder #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…center blocks refactored
|
Thanks so much for picking this up @annamunk and for snagging the bug fixes as well! 🚀 |
|
Hi here! Hi @RCheesley ! Is there any possibility to merge this PR so we have the preference blocks inside the builder into Mautic? Thanks! All the best |
|
Hey @jacquesbh thanks for asking! We have not yet had anybody test and code review this PR, which is why it's not yet merged. If you can test it and report back via the Files changed > leave review button then we can get it merged. Check the readme for instructions on how to test! |
|
Hi @jacquesbh just checking in as to how you got on with testing? |
|
Hi!
Didn't have the time yet. I found out that the variables are available even
if the blocks are not, so I'm going with this for now, but I definitely
need to work on those blocks later!
Jacques Bodin-Hullin
…--
+33 (0)6 75 54 11 97
Le lun. 24 mars 2025, 13:16, Ruth Cheesley ***@***.***> a
écrit :
Hi @jacquesbh <https://github.com/jacquesbh> just checking in as to how
you got on with testing?
—
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRT42JDTFJZAZRSCDIM4D2V7ZTJAVCNFSM6AAAAABZKNVHWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBXHEZTEMRWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: RCheesley]*RCheesley* left a comment
(mautic/grapesjs-preset-mautic#46)
<#46 (comment)>
Hi @jacquesbh <https://github.com/jacquesbh> just checking in as to how
you got on with testing?
—
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRT42JDTFJZAZRSCDIM4D2V7ZTJAVCNFSM6AAAAABZKNVHWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBXHEZTEMRWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yeah the variables work by just typing them, but agree that the blocks are a nicer solution for the marketer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the work from "Added preference center blocks to GrapesJS builder" and introduces preference center blocks to the GrapesJS builder.
I encountered errors related to the preference center and prepared the following fixes:
Please let me know if any additional problems occur. I don't have much experience using these blocks in the old builder, but I tried to recreate their functionality.