Refactor graph types to classes. #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having classes instead of plain objects allows having
aliases for known graph types, it also allows the addition
of new graphs if they follow the same structure as other
graph types.
Example of the new API:
```javascript
functionPlot({
target: '#playground',
data: [
functionPlot.interval({ fn: 'x^2' }),
functionPlot.scatter({ fn: 'sin(x)', nSamples: 50 }),
functionPlot.polyline({ fn: 'x^3' }),
functionPlot.text({ text: 'foo', location: [1, 2] })
]
})
```
The existing object API is still supported and transformed into
the classes, moving forward, the class API is preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having classes instead of plain objects allows having aliases for known graph types, it also allows the addition of new graphs if they follow the same structure as other graph types.
Example of the new API:
The existing object API is still supported and transformed into the classes, moving forward, the class API is preferred.