Add graphType to key #351
Merged
Add graphType to key #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
Add the graphType to the key to handle graphType updates on the same function. Fix mauriciopoppe#344.
github-actions
bot
force-pushed
the
fix-scattered-not-removed
branch
from
8467941 to
2148355
Compare
|
Rebased. Now checks should also pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the graphType as part of the key during data join.
Before: After a join it could be possible that existing plots were left behind and never undraw, check this comment for more details #329 (comment)
After: After a join, because the key contains more properties (combination of
[function to graph, graphType]) the old datum would be considered unmatched so it'd get removed, then the new datum gets drawn as if it was new.Fixes #344, #329