Skip to content

Fix #344 Scatter graph updates #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix #344 Scatter graph updates #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5effa6b
Fix #344 Scatter graph updates
Linho1219 Apr 29, 2025
df0cd40
Remove extra default value
Linho1219 Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,11 @@ export class Chart extends EventEmitter.EventEmitter {
},
(d: any) => {
// The key is the function set or other value that uniquely identifies the datum.
return d.fn || d.r || d.x || d.text
// Add the graphType to the key to handle graphType updates on the same function (#344)
return JSON.stringify({
function: d.fn || d.r || d.x || d.text,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think about it, we could plot:

data: [
  {fn: 'x'},
  {fn: 'x'},
]

In which case the key would be x for both, each one should have a different key instead. I filed another bug to track this #346

graphType: d.graphType
})
}
)

Expand Down