Enhance cURL requests with User-Agent and error handling #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added User-Agent header to requests and improved cURL handling for media uploads so that sending also works for GoToSocial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added User-Agent header to requests and improved cURL handling for media uploads so that sending also works for GoToSocial.
To get IndieConnector working with GoToSocial as well, I had to make these changes. Apart from falling back to the Mastodon API v1 for image uploads, it should still work with other Mastodon instances too, although I haven’t tested that (only with GoToSocial). On my previous Mastodon instance, it was preferred not to upload huge images. Since I upload my originals to Kirby at 1800 px width, I’ll probably add a downscaling step around the line
$optimizedImagePath = $imagePath;. As I’m self-hosting my GoToSocial instance, posting huge images is )probably) fine right now. maybe we can make that configurable via an option later?