-
Notifications
You must be signed in to change notification settings - Fork 401
MSC3860: Media Download Redirects #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ce59930
Add media download redirect proposal
Fizzadar 964c19e
Add urls
Fizzadar 088789b
Rename
Fizzadar 916e1b3
Wrap content
Fizzadar 9807bf4
Add note about MSC proposal and implementation work
Fizzadar 6746c86
Add missing sections to MSC
Fizzadar 6767a51
Rework to be opt-in via query param
Fizzadar aa14401
Fix typos
sumnerevans c9896a9
Clarify security considerations
sumnerevans 4b61481
Clarify that unstable prefix should be used
sumnerevans c2e9d45
Add 308 status code for redirects
Fizzadar 117f90c
Add clarification about no/false redirect param
Fizzadar bf2d22c
Add link to current spec media endpoints
Fizzadar a7733d9
Add note about additional benefit of not proxying untrusted homeserve…
Fizzadar 9312cb3
Expand issues section to cover possible homeserver abuse
Fizzadar 2b93616
fix a typo
anoadragon453 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# MSC3860: Media Download Redirects | ||
anoadragon453 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Currently the media download endpoints must return either a 200 with content or error responses. This | ||
means the media server instance must stream the data from wherever it is stored, which is likely not | ||
local to itself. Allowing redirects on these endpoints would make it possible for the media repo to | ||
tell clients/servers to pull data direct from the source, eg. a CDN. | ||
|
||
## Proposal | ||
|
||
This MSC proposes that a 307 redirect code is allowed and followed according to the `Location` | ||
Fizzadar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
header. It is possible some clients would already follow these which needs to be confirmed. Specifc | ||
endpoints in question: | ||
|
||
+ `/_matrix/media/v3/download/{serverName}/{mediaId}` | ||
+ `/_matrix/media/v3/download/{serverName}/{mediaId}/{fileName}` | ||
+ `/_matrix/media/v3/thumbnail/{serverName}/{mediaId}` | ||
anoadragon453 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
To prevent breaking clients that don't properly follow the redirect response this functionality will | ||
be enabled by a query string flag `allow_redirect=true`. So specifically in the above cases if a | ||
client respects redirect responses it can make requests like so to the media endpoints: | ||
anoadragon453 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
+ `/_matrix/media/v3/download/{serverName}/{mediaId}?allow_redirect=true` | ||
+ `/_matrix/media/v3/download/{serverName}/{mediaId}/{fileName}?allow_redirect=true` | ||
+ `/_matrix/media/v3/thumbnail/{serverName}/{mediaId}?allow_redirect=true` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The next versioned media endpoints after this MSC gets accepted (e.g. if MSC3911 gets accepted) should drop the |
||
|
||
## Potential Issues | ||
|
||
None, as opt-in functionality this change is 100% backwards compatible. | ||
|
||
## Alternatives | ||
|
||
None at this time. | ||
|
||
## Security Considerations | ||
|
||
A media repo could redirect requests to a bad actor, although this would make the primary media | ||
repo itself a bad actor, this does present any increased security issues. | ||
|
||
## Unstable Prefix | ||
|
||
No need for an unstable prefix for redirects as it stands. If a query string was to be used to | ||
enable this functionality this could use the following unstable prefix: | ||
|
||
``` | ||
?com.beeper.msc3860.allow_redirect=true | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.