-
Notifications
You must be signed in to change notification settings - Fork 401
MSC2516: Add a new message type for voice messages #2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3a7d67f
Create wip.md
ludwigbald 4607d6d
Rename wip.md to 2516-new-type-for-voice-messages.md
ludwigbald a85b80d
Update proposals/2516-new-type-for-voice-messages.md
ludwigbald e93cf14
Update 2516-new-type-for-voice-messages.md
ludwigbald 87ac8dd
Update 2516-new-type-for-voice-messages.md
ludwigbald 442b900
Update 2516-new-type-for-voice-messages.md
ludwigbald f9ac5d2
Updated the proposal
ludwigbald 30100fa
typo
ludwigbald 19d4d5c
typo: Update proposals/2516-new-type-for-voice-messages.md
ludwigbald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Add a seperate message type for voice messages | ||
ludwigbald marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
In the matrix spec right now, there is a message type `m.audio` for audio files. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. link to https://matrix.org/docs/spec/client_server/r0.6.1#m-audio would be helpful here. |
||
In other messaging apps, there is also a special type for voice memos, since they carry a different meaning and inflict different behaviour. | ||
This MSC calls for the introduction of an `m.voice` message type. | ||
|
||
|
||
## Proposal | ||
|
||
Even if it's not the primary mode of communication for nerds, | ||
ludwigbald marked this conversation as resolved.
Show resolved
Hide resolved
|
||
voice memos are very important to a lot of users of modern instant messaging services. | ||
In order to provide awesome voice messages, they need to be treated differently from generic audio files. | ||
|
||
For example, WhatsApp renders them differenty, to hihglight that they are a way of communication. | ||
ludwigbald marked this conversation as resolved.
Show resolved
Hide resolved
|
||
WhatsApp also always force-downloads them, because like a text message, they should be available to consume as early as possible. | ||
This lets the recipient know at a glance that they are being expected to listen to the voice messages now, | ||
instead of later. | ||
|
||
So, I propose to introduce a new message type `m.voice` with the same contents as `m.audio`, but to be handled slightly differently. | ||
|
||
## Potential issues | ||
|
||
Introducing a new message type means that client developers will have to do work to implement it, | ||
or many people won't be able to use the feature. | ||
|
||
## Alternatives | ||
ludwigbald marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Alternatively, a flag `voice = true` or `type = "voice"` could be created inside of the `m.audio` event. | ||
I'm not sure what the more canonical way of doing things would be here. | ||
ludwigbald marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Security considerations | ||
|
||
none | ||
ludwigbald marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.