Skip to content

Expose functionality for encrypted history sharing #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jul 1, 2025

Expose the new MSC4268 support that was added in matrix-sdk-crypto v0.12.0 (and gained indexeddb support in matrix-sdk-indexeddb v0.13.0).

Part of element-hq/element-meta#2871.

@richvdh richvdh force-pushed the rav/share_history_on_invite branch 2 times, most recently from 114ef63 to 1a081dc Compare July 1, 2025 10:10
@richvdh richvdh force-pushed the rav/share_history_on_invite branch 4 times, most recently from 28b69c9 to 33806ea Compare July 11, 2025 14:16
@richvdh richvdh marked this pull request as ready for review July 11, 2025 14:25
@richvdh richvdh requested a review from a team as a code owner July 11, 2025 14:25
@richvdh richvdh requested a review from BillCarsonFr July 11, 2025 14:25
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

fn from(value: matrix_sdk_crypto::store::types::StoredRoomKeyBundleData) -> Self {
let url = value.bundle_data.file.url.to_string();
let encryption_info =
serde_json::to_string(&MediaEncryptionInfo::from(value.bundle_data.file)).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would perhaps be nicer to expect() here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants