Skip to content

feat(base): Remember the inviter if we accept an invite #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Jul 11, 2025

Another PR that is a prerequisite of #5322.

Par of #4926.

  • Public API changes documented in changelogs (optional)

@poljar poljar requested a review from a team as a code owner July 11, 2025 17:48
@poljar poljar requested review from Hywan and removed request for a team July 11, 2025 17:48
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (edd371b) to head (d38285b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/room/room_info.rs 70.00% 3 Missing ⚠️
crates/matrix-sdk/src/client/mod.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5390   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files         334      334           
  Lines       91280    91317   +37     
  Branches    91280    91317   +37     
=======================================
+ Hits        81040    81078   +38     
+ Misses       6410     6409    -1     
  Partials     3830     3830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar force-pushed the poljar/shared-history/invite-acceptance-details branch from b56cd46 to 46a4580 Compare July 11, 2025 18:10
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, thanks for the work. I'm leaving one question, not a blocker.

@poljar poljar force-pushed the poljar/shared-history/invite-acceptance-details branch from 46a4580 to d38285b Compare July 12, 2025 08:46
@poljar poljar enabled auto-merge (rebase) July 12, 2025 08:49
@poljar poljar self-assigned this Jul 12, 2025
@poljar poljar merged commit 6de4032 into main Jul 12, 2025
43 checks passed
@poljar poljar deleted the poljar/shared-history/invite-acceptance-details branch July 12, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants