Skip to content

IndexedDB: Add IndexedDB implementation of EventCacheStore::load_last_chunk #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mgoldenberg
Copy link
Contributor

Background

This pull request is part of a series of pull requests to add a full IndexedDB implementation of the EventCacheStore (see #4617, #4996, #5090, #5138, #5226, #5274, #5343). This particular pull request focuses on providing an implementation of EventCacheStore::load_last_chunk.

Changes

The primary change is the addition of EventCacheStore::load_last_chunk, as well as tests for ensuring this is functioning correctly.

There are also a number of additions to IndexeddbEventCacheStoreTransaction which support the implementation of EventCacheStore::load_last_chunk.

  • get_chunk_by_next_chunk_id
  • get_chunks_count_in_room
  • get_max_chunk_id

These are simply typed wrappers around the generic functions in IndexeddbEventCacheStoreTransaction.

Future Work

  • Add remaining implementations of EventCacheStore functions without relying on MemoryStore.

  • Public API changes documented in changelogs (optional)

Signed-off-by: Michael Goldenberg m@mgoldenberg.net

Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…last_chunk

Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
… last chunk

Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…rsions

Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…ad_last_chunk

Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (d68895f) to head (26eec01).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5384      +/-   ##
==========================================
- Coverage   88.79%   88.79%   -0.01%     
==========================================
  Files         334      334              
  Lines       91143    91143              
  Branches    91143    91143              
==========================================
- Hits        80928    80927       -1     
- Misses       6390     6391       +1     
  Partials     3825     3825              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgoldenberg mgoldenberg marked this pull request as ready for review July 9, 2025 17:25
@mgoldenberg mgoldenberg requested a review from a team as a code owner July 9, 2025 17:25
@mgoldenberg mgoldenberg requested review from poljar and removed request for a team July 9, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant