refactor(sdk): Convert some tests to the MatrixMockServer and MockClientBuilder APIs #5351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #5351 +/- ##
==========================================
- Coverage 88.76% 88.73% -0.03%
==========================================
Files 333 333
Lines 90326 90381 +55
Branches 90326 90381 +55
==========================================
+ Hits 80177 80204 +27
- Misses 6325 6352 +27
- Partials 3824 3825 +1 ☔ View full report in Codecov by Sentry. |
Usually tests that don't construct it via MockMatrixServer don't care about the homeserver URL, so this allows to provide a default URL for them. Also we don't force to allocate a string when the inner API actually uses a borrowed string. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Since there are several places that use it. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…f MockClientBuilder Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
zecakeh
changed the title
…ilder Because it's such a nicer API! Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…Builder Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…Builder Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of commits to improve the APIs first, and then all the tests from
crates/matrix-sdk/src/client/mod.rs,crates/matrix-sdk/src/sliding_sync/client.rsandcrates/matrix-sdk/tests/integration/media.rsare converted to those APIs.Note that those 3 files were not chosen randomly, some of the tests there fail in #5337, and one of the simplest solutions for fixing them involves porting them to the newer APIs.
This can be reviewed commit by commit.