Skip to content

Upgrade Ruma #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Upgrade Ruma #5347

merged 1 commit into from
Jul 4, 2025

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Jul 3, 2025

Contrary to #5337 which updates Ruma on the main branch (which is not ready for a release yet), this updates Ruma on the ruma-0.12 branch which can be released at any time.

The changes here are due to the stabilization of unstable features.

@zecakeh zecakeh requested a review from a team as a code owner July 3, 2025 14:31
@zecakeh zecakeh requested review from Hywan and removed request for a team July 3, 2025 14:31
"client-api-c",
"compat-upload-signatures",
"compat-user-id",
"compat-arbitrary-length-ids",
"compat-tag-info",
"compat-encrypted-stickers",
"compat-lax-room-create-deser",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new compat feature that allows some fields of m.room.create events to be ignored if they fail during deserialization. That way we can still access the other properties of the event.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (bedcbfd) to head (49a5e18).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/authentication/oauth/mod.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5347   +/-   ##
=======================================
  Coverage   88.74%   88.75%           
=======================================
  Files         333      333           
  Lines       90248    90247    -1     
  Branches    90248    90247    -1     
=======================================
+ Hits        80095    80103    +8     
+ Misses       6327     6319    -8     
+ Partials     3826     3825    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good.

@poljar poljar merged commit 5448192 into matrix-org:main Jul 4, 2025
45 checks passed
@zecakeh zecakeh deleted the bump-ruma-0.12 branch July 4, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants