feat(base): Remember when a user accepts an invite #5333
Conversation
poljar
force-pushed
the
poljar/shared-history/join-timestamp
branch
from
2b0094c to
b5c854a
Compare
| /// This is useful to remember if the user accepted this a join on using | ||
| /// this specific client. |
There was a problem hiding this comment.
Something's off here, needs rewording I reckon.
There was a problem hiding this comment.
Just a leftover from the previous version of this sentence.
| /// | ||
| /// This is useful to remember if the user accepted this a join on using | ||
| /// this specific client. | ||
| pub(crate) invite_accepted_at: Option<MilliSecondsSinceUnixEpoch>, |
There was a problem hiding this comment.
I never do know how these work: does it need a serde default or some special migration to not break old instances?
There was a problem hiding this comment.
A missing field or a null are treated the same if Option is used. I guess we could add a skip_serializing here since this field will in most cases be None.
There was a problem hiding this comment.
Heh, nice, thank you! 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5333 +/- ##
=======================================
Coverage 88.74% 88.75%
=======================================
Files 333 333
Lines 90157 90197 +40
Branches 90157 90197 +40
=======================================
+ Hits 80010 80050 +40
- Misses 6321 6322 +1
+ Partials 3826 3825 -1 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/shared-history/join-timestamp
branch
from
b5c854a to
d877ecb
Compare
poljar
force-pushed
the
poljar/shared-history/join-timestamp
branch
from
d877ecb to
032b8a7
Compare
I think that this is necessary to make #5322 somewhat secure.
Part of #4926.