Skip to content

refactor(ffi): Drop support for observing AccountDataEventType::SecretStorageKey #5326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Jul 2, 2025

This type cannot be observed because it is a dynamic event type and this branch will fail to compile with the next version of Ruma.

…tStorageKey

This type cannot be observed and this branch will fail to compile with
the next version of Ruma.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner July 2, 2025 06:51
@zecakeh zecakeh requested review from andybalaam and removed request for a team July 2, 2025 06:51
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (a9ffe5f) to head (e26c4e9).
Report is 28 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5326   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         333      333           
  Lines       90228    90228           
  Branches    90228    90228           
=======================================
+ Hits        80088    80091    +3     
+ Misses       6315     6312    -3     
  Partials     3825     3825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +575 to +576
/// Doesn't work for `m.secret_storage.key.<key_id>`, because it is
/// currently not observable.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we are adding stuff to Ruma that should make this possible in the future (ruma/ruma#2136), although the event handler code will need to be adapted in the SDK.

So maybe it's better not to touch the function signature and panic for now?

@andybalaam andybalaam requested review from poljar and removed request for andybalaam July 2, 2025 08:49
@zecakeh zecakeh marked this pull request as draft July 2, 2025 09:04
@zecakeh
Copy link
Collaborator Author

zecakeh commented Jul 2, 2025

Actually what we have in ruma/ruma#2136 is probably not the right answer. We might need to do another breaking change that will require changes to the event handler code and fix this.

@zecakeh
Copy link
Collaborator Author

zecakeh commented Jul 2, 2025

There is a fix for this in #5337 so we might not need this. We could make #5337 smaller by merging a version of this (since the current code doesn't work anyway), and then applying the fix in another PR after #5337.

@zecakeh
Copy link
Collaborator Author

zecakeh commented Jul 2, 2025

Actually we found a way where we don't need to fix anything until after Ruma is bumped.

@zecakeh zecakeh closed this Jul 2, 2025
@zecakeh zecakeh deleted the rm-observe-secret-storage-key branch July 2, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant