-
Notifications
You must be signed in to change notification settings - Fork 315
feat(wasm): add feature support for indexedb and sqlite to matrix-sdk-ffi #5245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zzorba
wants to merge
18
commits into
matrix-org:main
Choose a base branch
from
filament-dm:wasm_indexedb_and_sqlite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+354
−135
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1ea1398
Change matrix-sdk-ffi to rely on features over platform targets
bd2de9c
Set up feature flags for new indexeddb and sqlite choices
6c5cfeb
Add support for indexeddb and sqlite session choice
a148409
fix capitlizations
629b610
fix some bad merges
5dc20db
Add sqlite to the ci task, refactor code to make cfg clearer
4cde428
Cargo fmt
15ea884
Make constructor return Arc properly
fe98e31
Add indexeddb includes
ebebe34
Update bindings/matrix-sdk-ffi/CHANGELOG.md
zzorba fc92feb
Update bindings/matrix-sdk-ffi/Cargo.toml
zzorba 4543b1b
Update bindings/matrix-sdk-ffi/Cargo.toml
zzorba 69538a5
Update bindings/matrix-sdk-ffi/src/session_store.rs
zzorba 7987cc2
Code review feedback
1d844de
Rename builder
ce33b96
Adjust language in the README
90048a8
Make it an xor
5c93af9
Use Self instead
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
It should be a fixup patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what that means. What is a fixup patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A fixup patch is a patch that is “melt”/“merged” with another one so that we end up with a single patch, see https://git-scm.com/docs/git-rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contributing guide also explains it: https://github.com/matrix-org/matrix-rust-sdk/blob/main/CONTRIBUTING.md#addressing-review-comments-using-fixup-commits.