feat(ffi): Add ability to configure indexedb instead of sqlite for wasm platforms #5181
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,17 +14,17 @@ publish = false | |
| release = true | ||
|
|
||
| [lib] | ||
| crate-type = ["cdylib", "staticlib", "lib"] | ||
|
|
||
| [features] | ||
| default = ["bundled-sqlite", "unstable-msc4274"] | ||
| bundled-sqlite = ["matrix-sdk/bundled-sqlite"] | ||
| unstable-msc4274 = ["matrix-sdk-ui/unstable-msc4274"] | ||
| js = [] | ||
|
|
||
| [dependencies] | ||
| anyhow.workspace = true | ||
| as_variant.workspace = true | ||
| extension-trait = "1.0.1" | ||
| eyeball-im.workspace = true | ||
| futures-util.workspace = true | ||
|
|
@@ -36,21 +36,18 @@ matrix-sdk-ui = { workspace = true, features = ["uniffi"] } | |
| mime = "0.3.16" | ||
| once_cell.workspace = true | ||
| ruma = { workspace = true, features = ["html", "unstable-unspecified", "unstable-msc3488", "compat-unset-avatar", "unstable-msc3245-v1-compat", "unstable-msc4278"] } | ||
| serde.workspace = true | ||
| serde_json.workspace = true | ||
| thiserror.workspace = true | ||
| tracing.workspace = true | ||
| tracing-appender = { version = "0.2.2" } | ||
| tracing-core.workspace = true | ||
| tracing-subscriber = { workspace = true, features = ["env-filter"] } | ||
| url.workspace = true | ||
| uuid = { version = "1.4.1", features = ["v4"] } | ||
| zeroize.workspace = true | ||
|
|
||
| [target.'cfg(all(not(target_os = "android"), not(target_family = "wasm")))'.dependencies.matrix-sdk] | ||
| workspace = true | ||
| features = [ | ||
| "anyhow", | ||
|
|
@@ -64,7 +61,7 @@ features = [ | |
| "uniffi", | ||
| ] | ||
|
|
||
| [target.'cfg(all(not(target_os = "android"), not(target_family = "wasm")))'.dependencies.sentry] | ||
| version = "0.36.0" | ||
| default-features = false | ||
| features = [ | ||
|
|
@@ -77,6 +74,31 @@ features = [ | |
| "reqwest", | ||
| ] | ||
|
|
||
| [target.'cfg(target_family = "wasm")'.dependencies] | ||
| matrix-sdk-ui = { workspace = true, features = ["js", "uniffi"] } | ||
| tokio = { workspace = true, features = ["sync", "macros"] } | ||
| uniffi = { workspace = true, features = [] } | ||
|
|
||
| [target.'cfg(target_family = "wasm")'.dependencies.matrix-sdk] | ||
| workspace = true | ||
| features = [ | ||
| "anyhow", | ||
| "e2e-encryption", | ||
| "experimental-widgets", | ||
| "markdown", | ||
| "rustls-tls", | ||
| "socks", | ||
| "indexeddb", | ||
| "uniffi", | ||
| ] | ||
|
There was a problem hiding this comment. All the changes in There was a problem hiding this comment. Opened up #5211 which is nearly merged. I will rebase this branch with those changes (and other feedback) once it lands. |
||
|
|
||
| [target.'cfg(not(target_family = "wasm"))'.dependencies] | ||
| async-compat.workspace = true | ||
| matrix-sdk-ui = { workspace = true, features = ["uniffi"] } | ||
| sentry-tracing = "0.36.0" | ||
| tokio = { workspace = true, features = ["rt-multi-thread", "macros"] } | ||
| uniffi = { workspace = true, features = ["tokio"] } | ||
|
|
||
| [target.'cfg(target_os = "android")'.dependencies] | ||
| paranoid-android = "0.2.1" | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's related to what the patch says it does. Can you split this in another patch please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this seems weird, what's the idea with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The uniffi bindings generator requires the library to be built as a "lib" so it can be included in a second generated-rust library that is fed through. But I will break that out into a second PR.