Skip to content

feat(ffi): Add reply_params to GalleryUploadParameters #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 4, 2025

Looks like I forgot adding this in #5163, sorry. Everything below the FFI layer was already prepared for replies.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

Johennes added 2 commits June 4, 2025 20:02
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes marked this pull request as ready for review June 4, 2025 18:14
@Johennes Johennes requested a review from a team as a code owner June 4, 2025 18:14
@Johennes Johennes requested review from andybalaam and removed request for a team June 4, 2025 18:14
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.94%. Comparing base (0777e6e) to head (bbfa2f6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5173      +/-   ##
==========================================
+ Coverage   85.93%   85.94%   +0.01%     
==========================================
  Files         336      336              
  Lines       36866    36866              
==========================================
+ Hits        31680    31685       +5     
+ Misses       5186     5181       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@andybalaam andybalaam merged commit b8ae210 into matrix-org:main Jun 5, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants