Skip to content

Add new account data for MSC4155 #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add new account data for MSC4155 #4766

wants to merge 1 commit into from

Conversation

Half-Shot
Copy link
Contributor

matrix-org/matrix-spec-proposals#4155

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@Half-Shot Half-Shot requested a review from a team as a code owner March 27, 2025 14:19
@Half-Shot Half-Shot requested review from dbkr and MidhunSureshR March 27, 2025 14:19
@Half-Shot Half-Shot mentioned this pull request Mar 27, 2025
Merged
4 tasks
t3chguy
t3chguy requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it has no point being in the js-sdk for an MSC PoC. Why not have it just live in the application you wish to support it, presumably EW? AccountDataEvents is extensible by the host app

@Half-Shot Half-Shot closed this Mar 27, 2025
@Half-Shot Half-Shot deleted the hs/invite-filtering-settings branch April 10, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy requested changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @t3chguy