CI: Harden GHA configuration #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the possibility of a tag being changed under us.
May include: - Avoids risky string interpolation. - Prevents checkout premissions from leaking
Reduces risk of arbitrary code is run by attacker.
QuLogic
reviewed
Jul 22, 2025
.github/workflows/testing.yml
Outdated
| @@ -41,4 +44,4 @@ jobs: | |||
| coverage report | |||
|
|
|||
| - name: Upload code coverage | |||
| uses: codecov/codecov-action@v1 | |||
| uses: codecov/codecov-action@29386c70ef20e286228c72b668a06fd0e8399192 # v1 | |||
There was a problem hiding this comment.
This is pretty outdated, since it's at v5 now, but if you don't want to update it here, probably set the comment to v1.5.2 so that dependabot will update to specific versions instead of the major version.
.github/workflows/docs.yml
Outdated
| @@ -17,7 +21,7 @@ jobs: | |||
| run: make -Cdoc html | |||
| - name: Publish | |||
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} | |||
| uses: peaceiris/actions-gh-pages@v3 | |||
| uses: peaceiris/actions-gh-pages@373f7f263a76c20808c831209c920827a82a2847 # v3 | |||
There was a problem hiding this comment.
Also outdated, but can set the comment to v3.9.3 to match the commit ref.
|
I did not do any updating as part of this wave of PRs. The plan in my head was to rely on dependabot to fix that in a second pass. |
QuLogic
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply recommended hardening steps including: