Skip to content

CI: Harden GHA configuration #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@

version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/" # Location of your workflow files
schedule:
interval: "weekly" # Options: daily, weekly, monthly
10 changes: 7 additions & 3 deletions .github/workflows/circleci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: Run CircleCI artifacts redirector
steps:
- name: GitHub Action step
uses: larsoner/circleci-artifacts-redirector-action@master
uses: scientific-python/circleci-artifacts-redirector-action@7eafdb60666f57706a5525a2f5eb76224dc8779b # v1.1.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
artifact-path: 0/doc/build/html/index.html
Expand All @@ -27,15 +27,19 @@ jobs:
name: Post warnings/errors as review
steps:
- uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pinning this one to a commit?

with:
persist-credentials: false

- name: Fetch result artifacts
id: fetch-artifacts
run: |
python .circleci/fetch_doc_logs.py "${{ github.event.target_url }}"
python .circleci/fetch_doc_logs.py "${GITHUB_EVENT_TARGET_URL}"
env:
GITHUB_EVENT_TARGET_URL: ${{ github.event.target_url }}

- name: Set up reviewdog
if: "${{ steps.fetch-artifacts.outputs.count != 0 }}"
uses: reviewdog/action-setup@v1
uses: reviewdog/action-setup@e04ffabe3898a0af8d0fb1af00c188831c4b5893 # v1.3.2
with:
reviewdog_version: latest

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the actions are pinned to commit in this file.

Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
---

name: Release
permissions:
contents: read
on:
release:
types:
Expand All @@ -14,6 +16,7 @@ jobs:
- uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not pinned to a commit.

with:
fetch-depth: 10
persist-credentials: false

- name: Set up Python
id: setup
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
---
name: Linting
permissions:
contents: read
on:
push:
branches-ignore:
Expand All @@ -13,6 +15,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up Python 3
uses: actions/setup-python@v4
Expand Down Expand Up @@ -47,6 +51,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false

- name: Set up Python
uses: actions/setup-python@v4
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
---

name: Tests
permissions:
contents: read

on:
push:
Expand All @@ -22,6 +24,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand All @@ -42,4 +45,4 @@ jobs:
pytest -raR -n auto --cov --cov-report=

- name: Upload code coverage
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457 # v3.1.6
Loading