Skip to content

Adding tests to verify cloud patterns #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Conversation

jm9176
Copy link
Member

@jm9176 jm9176 commented Jun 23, 2025

Added positive testpoint as discussed offline. The negative test was already as part of a separate testpoint, so I am not adding anything new to verify the error.

@jm9176 jm9176 requested a review from krisfed June 23, 2025 18:10
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (c2f9646) to head (bd8bb33).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files           8        8           
  Lines         214      214           
=======================================
  Hits          207      207           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@krisfed krisfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you, Shubh!

% This list contains path pattern currently supported by Zarr
% in MATLAB. Any invalid path not matching any of these
% patterns will result in an error.
inpPath = {'https://mybucket.s3.us-west-2.amazonaws.com/path/to/myZarrFile', ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious - why cell array of char vectors instead of a more modern array of strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing specific.

'https://s3.eu-central-1.example.edu/mybucket/path/to/myZarrFile', ...
's3://mybucket/path/to/myZarrFile'};

for i = 1:length(inpPath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor and somewhat subjective, but you can use a for-each loop if you don't need the index i for anything else other than getting the current path

paths = ["path1", "path2", "path3"]; % has to be a row vector
for p = paths % iterate over the array of strings directly instead of using index
disp(p)
end

That way you don't have to keep doing {i} to access the current path. Alternatively, can save the current path to a separate variable first currPath = inpPath{i}.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but keeping it as is for now, for better readability.

@jm9176 jm9176 merged commit 3a7b0a3 into main Jun 24, 2025
6 checks passed
@jm9176 jm9176 deleted the cloud_pattern_test_branch branch June 25, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants