Fix Key.sign method and add test for it #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puiterwijk
force-pushed
the
fix_sign
branch
2 times, most recently
from
84c7a09 to
c6abe02
Compare
mathstuf
requested changes
Dec 16, 2020
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
The truncate() method doesn't do anything if the "len" is greater than the current length, which is the case here. So instead, use the Vec.set_len method. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The truncate() method doesn't do anything if the "len" is greater
than the current length, which is the case here.
So instead, use the Vec.set_len method.