Skip to content

Conversation

@mathemancer
Copy link
Contributor

Related to #4926 #4824 #4235

This adds materialized and non-materialized views to table listing functionality in Mathesar. This means that views show up in the schema page (as tables, since the FE has no way to differentiate)

Technical details

This PR is just an experiment to see what our current behavior is when views are returned by the API along with tables. This is also related to our public "Insider Trading" dataset initiative, since we could, given read-only views, improve performance by using them instead of explorations on that (extremely large) dataset.

I'll use this PR to record notes about the behavior.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer
Copy link
Contributor Author

mathemancer commented Oct 28, 2025

First of all, there's no indication anywhere that a view is a view rather than a table (other than in error messages).

Schema page

  • View shown as table
  • Description displayed correctly
  • "Find a record" button shows normal response for "table" without pkey:
    image
  • Renaming the "table" doesn't work (why??)
  • Permissions management: TODO

Table Page

  • filters, sorting, grouping: Working as normal.

Inspector: Table

  • "Table" renaming: Working as normal.
  • Reading description: Working
  • Setting description: Not working, no error shown.
  • Permissions management TODO
  • Create relationship, which should make a column in the view: Not working (can't work; you can't add an fkey column to a view). Reasonable error:
    image
  • Create relationship, with an fkey referencing the view. Not possible, reasonable error message:
    image
  • Create many-to-many relationship, not possible, reasonable error:
    image
  • Data Explorer working fine.
  • Record Summaries shows reasonable message:
    image
  • Import is disabled (good)
  • Export works normally
  • Deleting fails, reasonable message:
    image

Inspector: Column

  • Renaming: working as normal
  • Reading/Setting description: working as normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants