-
-
Couldn't load subscription status.
- Fork 404
Export explorations #4854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export explorations #4854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend code mostly looks good, but I did have a suggestion to tidy up the chunking logic.
Given that this way of doing things requires holding the entire result in memory, please add a hard limit somewhere to keep the service safe. This should probably be in the chunker or something. No more than (say) 50k rows should ever be fetched and returned.
Co-authored-by: Brent Moran <brentmoran@gmail.com>
mathesar_ui/src/component-library/anchorButton/AnchorButton.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend code looks good, if you merge my suggestion. Otherwise, re-request review, please!
Please wait for another frontend review after sorting out the UI behavior when the limit cap is reached (e.g., throwing a warning, some tooltip, whatever)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anish9901 I had one comment.
As discussed in the engineering call, I'll take a look again once the tooltip to inform the user that the export would be limited to 50k rows is implemented.
mathesar_ui/src/component-library/anchorButton/AnchorButton.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Brent Moran <brentmoran@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anish9901 The code changes look good. Nice work!
I added a small commit to make the text displayed to the user a bit more friendly: 39ebcb7
Fixes #4619
Adds the ability to export saved explorations along with applied transformations as a CSV file.
The "Export" button on the data explorer page has the following hover text and state:
When there are no columns in an unsaved exploration(button disabled and no help text):
When the exploration is unsaved(button disabled with help text):
When the exploration is saved(button enabled with help text):
Checklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin