-
-
Couldn't load subscription status.
- Fork 404
Alter column refactor #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter column refactor #4787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks good overall!
I noticed that this adds to the number of long lines (i.e., over 100 characters) in the 05_msar.sql file, but they're not the only ones. @Anish9901 Please make an issue to spend a few minutes reducing line lengths in this file. The long lines wreck my workflow, since I use psql to look at function docstrings and bodies.
Fixes #4427
Fixes #4425
Fixes #4428
This refactor aims to:
msar.alter_columnsfunction, to enable eaiser debugging.This is achieved in this PR by executing separate queries for alter operations rather than combining them into a giant SQL
ALTERstatement.Checklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin