Skip to content

Implement FileInput component for record page #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 17, 2025
Merged

Implement FileInput component for record page #4779

merged 6 commits into from
Sep 17, 2025

Conversation

@seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Sep 16, 2025 •
edited
Loading

Fixes item 9 on our Files UI checklist.

⚠️ Don't merge until base branch becomes file_attachment_feature ⚠️

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the v0.6.0 milestone Sep 16, 2025
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Sep 16, 2025
@seancolsen seancolsen changed the base branch from develop to files_column_config September 16, 2025 23:48
@seancolsen seancolsen marked this pull request as draft September 16, 2025 23:50
@seancolsen seancolsen marked this pull request as ready for review September 17, 2025 12:05
pavish
pavish reviewed Sep 17, 2025
View reviewed changes
mathesar_ui/src/systems/record-selector/RecordSelectorColumnHeaderCell.svelte Outdated
key: recordId,
value: _recordSummary,
})}
canUploadFile={false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The record selector header should be using the same input as the filter input, as in the search boxes are essentially filters. That would remove the need to use canUploadFile here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed f833138 for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right on. Thanks

mathesar_ui/src/components/cell-fabric/DynamicInput.svelte Outdated
Comment on lines 26 to 27
fileManifest?: FileManifest = undefined;
setFileManifest?: ((mash: string, manifest: FileManifest) => void) = undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values should be removed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a7c65c6 to fix this

mathesar_ui/src/components/cell-fabric/DynamicInput.svelte Outdated
during Sheet component creation.
-->
<script lang="ts">
import type { FileManifest } from '@mathesar/api/rpc/records';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier seems to break due to the $$Props interface containing values.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a7c65c6 to fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch. Thanks. Weird that TS didn't complain about this!

pavish
pavish approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seancolsen The functionality looks good to me. I had a few comments.

I pushed the following commits to fix them:

  • a7c65c6: Removes default values from an interface. It looks like it was probably an oversight, which also broke prettier. On a side note, prettier seems to pass when it isn't able to parse a file, we should take a look at that sometime.
  • f833138 removes the canUploadFile prop and uses the same input components used with filters for the record selector search boxes and default value input.
    • The search box in record selector is a textbox now and it is explicitly disabled, until we allow users to search by names or other properties of files.
    • The default input is a textbox. The user could specify some valid default value if needed. I don't think validation is a priority for this one for the MVP.

Let me know if you disagree with any of these commits.

This PR can be merged once #4770 is merged.

@pavish pavish added pr-status: prepared A PR that has been reviewed and approved but is waiting on base PRs to merge first. and removed pr-status: review A PR awaiting review labels Sep 17, 2025
Base automatically changed from files_column_config to file_attachment_feature September 17, 2025 22:31
@pavish pavish added this pull request to the merge queue Sep 17, 2025
Merged via the queue into file_attachment_feature with commit 4d882d6 Sep 17, 2025
22 checks passed
@pavish pavish deleted the files_input branch September 17, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavish pavish pavish approved these changes

Assignees

@pavish pavish

Labels

pr-status: prepared A PR that has been reviewed and approved but is waiting on base PRs to merge first.

Projects

None yet

Milestone

v0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seancolsen @pavish