-
-
Couldn't load subscription status.
- Fork 406
File attachment feature #4757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File attachment feature #4757
Conversation
…aphic hashing algorithm on sensitive data Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
A few small Files fixes
…load Prevent file upload in disabled cells
Improve lightbox display for extra small images
…kgrounds Better lightbox background for transparent and small images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work @mathemancer @seancolsen @pavish @Anish9901 @zackkrida! Looks great!
I'm approving but I have two issues that would be good to fix before release (they don't have to block merge).
Issue 1
The buttons on this modal are too far apart. I recommend consolidating them in the center.
Issue 2
This copy is not relevant to most end users and increases cognitive load. It is primarily only relevant to Mathesar admins. We should have this caveat be prominently displayed in our docs, but we do not need to have this be a message here.
It's okay if we have a confirmation dialog, I just don't want the copy about the file reference.
|
Awesome, thanks @kgodey! I'll create standalone issues for the UI changes you've identified, and we'll fix them this week as part of QA. |
This is a tracking branch for the File Attachments feature. All changes in this branch have already been reviewed in other PRs.
This PR will be ready to merge once we've decided that the Files feature is ready for release.
Testing Instructions
Setup
git checkout file_attachment_featureorgh pr checkout 4757cp file_storage.yml.example file_storage.ymldocker compose -f docker-compose.dev.yml up obj-store dev-service --build # ^^^^^^^^^ THIS IS NEWTesting
Video
A very quick showcase of the core functionality:
Screencast.From.2025-09-22.11-19-21.mp4
Checklist
Update index.md).developbranch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin