Skip to content

Conversation

@seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Sep 10, 2025

This is a tracking branch for the File Attachments feature. All changes in this branch have already been reviewed in other PRs.

This PR will be ready to merge once we've decided that the Files feature is ready for release.

Testing Instructions

Setup

  1. Checkout this branch git checkout file_attachment_feature or gh pr checkout 4757
  2. Configure the default file backend by copying the example config cp file_storage.yml.example file_storage.yml
  3. Run Mathesar's dev service and the new local file storage container (MinIO) with:
    docker compose -f docker-compose.dev.yml up obj-store dev-service --build
    #                                           ^^^^^^^^^ THIS IS NEW
  4. Log into MinIO at localhost:9001. Username and password are both "mathesar".
  5. Create a new bucket called "mathesar-storages" in the UI.
  6. Go to Mathesar.

Testing

  1. Go to an existing table in your local Mathesar instance, or create a new schema with one of the pre-defined datasets and navigate to a table.
  2. Using the "+" icon, add a new "File" column to the table.
  3. Upload various files to cells. Images and non-images.
  4. Experiment with various aspects of the UI:
  • The single record view of a record with a file column
  • Attempting to add a file column to as form
  • The lightbox when clicking on an image thumbnail
  • The modal when clicking on an non-image file icon

Video

A very quick showcase of the core functionality:

Screencast.From.2025-09-22.11-19-21.mp4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

mathemancer and others added 30 commits August 7, 2025 16:26
…aphic hashing algorithm on sensitive data

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@zackkrida zackkrida marked this pull request as ready for review September 22, 2025 15:10
@zackkrida zackkrida requested a review from kgodey September 22, 2025 15:21
@zackkrida zackkrida added pr-status: review A PR awaiting review and removed pr-status: prepared A PR that has been reviewed and approved but is waiting on base PRs to merge first. labels Sep 22, 2025
Copy link
Contributor

@kgodey kgodey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work @mathemancer @seancolsen @pavish @Anish9901 @zackkrida! Looks great!

I'm approving but I have two issues that would be good to fix before release (they don't have to block merge).

Issue 1

Image

The buttons on this modal are too far apart. I recommend consolidating them in the center.

Issue 2

Image

This copy is not relevant to most end users and increases cognitive load. It is primarily only relevant to Mathesar admins. We should have this caveat be prominently displayed in our docs, but we do not need to have this be a message here.

It's okay if we have a confirmation dialog, I just don't want the copy about the file reference.

@zackkrida
Copy link
Member

Awesome, thanks @kgodey! I'll create standalone issues for the UI changes you've identified, and we'll fix them this week as part of QA.

@zackkrida zackkrida added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@zackkrida zackkrida added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@zackkrida zackkrida enabled auto-merge September 22, 2025 19:27
@zackkrida zackkrida added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@zackkrida zackkrida added this pull request to the merge queue Sep 22, 2025
@zackkrida zackkrida mentioned this pull request Sep 22, 2025
Merged via the queue into develop with commit 33a8785 Sep 22, 2025
262 of 368 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-status: review A PR awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants