-
Notifications
You must be signed in to change notification settings - Fork 54
Essential supremum #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Essential supremum #1606
Conversation
8793489
to
b2b1a93
Compare
The CI is failing because it fact the lemmas depends on lemmas in PR #1607 , which should therefore be merged first (and I think that they are ready for merge by the way). |
f132015
to
fc0cb94
Compare
62fb3f9
to
ea1962d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This theory has been written and re-written and scrutinized. Merging it will help clarify the "lspace master" PR a lot (and this means that we will have a chance to double-check it again when using it to rebase "lspace master"). Besides "lspace master"/"Bernoulli sampling" PRs, there is another application waiting for it. So I am all for merging it. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp> Co-authored-by: Cyril Cohen <cohen@crans.org> Co-authored-by: Pierre Roux <pierre.roux@onera.fr> Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
d65bd82
to
9587c95
Compare
* theory of essential supremum Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp> Co-authored-by: Cyril Cohen <cohen@crans.org> Co-authored-by: Pierre Roux <pierre.roux@onera.fr> Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
Motivation for this change
Introduces lemmas for essential supremum, part of the split of #1506
Note, this PR is itself based on #1600, it should only be merged after that(PR #1600 has been merged)Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers