Skip to content

Essential supremum #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

Conversation

hoheinzollern
Copy link
Member

@hoheinzollern hoheinzollern commented May 1, 2025

Motivation for this change

Introduces lemmas for essential supremum, part of the split of #1506

Note, this PR is itself based on #1600, it should only be merged after that (PR #1600 has been merged)

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@hoheinzollern hoheinzollern force-pushed the essential_supremum branch 2 times, most recently from 8793489 to b2b1a93 Compare May 1, 2025 08:24
@affeldt-aist
Copy link
Member

The CI is failing because it fact the lemmas depends on lemmas in PR #1607 , which should therefore be merged first (and I think that they are ready for merge by the way).

This was referenced May 1, 2025
@hoheinzollern hoheinzollern force-pushed the essential_supremum branch 2 times, most recently from f132015 to fc0cb94 Compare May 7, 2025 06:44
@hoheinzollern hoheinzollern mentioned this pull request May 8, 2025
2 tasks
@hoheinzollern hoheinzollern force-pushed the essential_supremum branch 4 times, most recently from 62fb3f9 to ea1962d Compare May 12, 2025 08:52
@affeldt-aist affeldt-aist self-requested a review May 12, 2025 10:08
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This theory has been written and re-written and scrutinized. Merging it will help clarify the "lspace master" PR a lot (and this means that we will have a chance to double-check it again when using it to rebase "lspace master"). Besides "lspace master"/"Bernoulli sampling" PRs, there is another application waiting for it. So I am all for merging it. Wdyt?

@affeldt-aist affeldt-aist requested a review from t6s May 13, 2025 06:05
Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

hoheinzollern and others added 3 commits May 14, 2025 09:10
Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
Co-authored-by: Cyril Cohen <cohen@crans.org>
Co-authored-by: Pierre Roux <pierre.roux@onera.fr>
Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
@affeldt-aist affeldt-aist merged commit d005b11 into math-comp:master May 14, 2025
34 checks passed
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Jun 20, 2025
* theory of essential supremum

Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
Co-authored-by: Cyril Cohen <cohen@crans.org>
Co-authored-by: Pierre Roux <pierre.roux@onera.fr>
Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants