-
Notifications
You must be signed in to change notification settings - Fork 130
[WIP] Update LOBSTER output files list #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] Update LOBSTER output files list #1044
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 72.82% 76.93% +4.11%
==========================================
Files 187 187
Lines 13637 13627 -10
Branches 1370 1372 +2
==========================================
+ Hits 9931 10484 +553
+ Misses 3161 2592 -569
- Partials 545 551 +6
|
|
Hey @naik-aakash and @JaGeo is this ready to be merged? Not sure if there's also a bump in the lobsterpy dependence that's needed |
|
Hi @esoteric-ephemera , its not yet ready, I will try to add some tests files by end of this week then ping you once am done. |
|
No rush at all! Trying to clear out older PRs / make sure they don't get stale |
Changes
With LOBSTER v>=5, There are new keywords added that enables generating new output files for specific types of analysis, ideally they should also get gzipped if user enables such calculations, thus this list of output has been updated
Todo