Skip to content

Conversation

@Maks-M-22
Copy link

  1. Add a severity attribute to each test.
  2. Add Allure hierarchy attributes: parentSuite, suite, and subSuite for each test.
  3. Add Allure hierarchy attributes: epic, feature, and user story for each test.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! You have successfully configured the Allure reporter and correctly added all the required attributes (severity, epic, feature, etc.) to every test file, fully meeting the project requirements.

As a minor suggestion for improving the report's clarity, consider aligning the suite and feature attributes with the test's location. For instance, in tests/customerSite/menu/viewCoffee/coffeeCupHasCorrectCost.spec.js, the suite is set to 'Cart', but the test is performed on the menu page. Changing this to 'Menu' would create a more intuitive report structure. This is not a required change, but something to keep in mind for consistency.

Great job completing this integration!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

await allure.subSuite('Add coffee');

await allure.epic(`Customer site`);
await allure.feature('Cart');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'feature' is set to 'Cart', but the test is located under the 'Menu' suite (await allure.suite('Menu'); on line 19). While adding a coffee to the total is related to cart functionality, the test itself is performed on the menu page. For better structural clarity in the Allure report, consider changing this to await allure.feature('Menu'); to match the suite.

await allure.severity('minor');

await allure.parentSuite(`Customer site`);
await allure.suite('Cart');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is located within the tests/customerSite/menu directory and exclusively tests functionality on the menuPage. However, you've set the suite to 'Cart'. For a more logical and clear Allure report structure, the suite should reflect the area of the application being tested.

Consider changing this to await allure.suite('Menu');.

The same applies to the feature on line 21, which should also likely be 'Menu'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants